New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore the base URL when the relative one is a complete URL #128

Merged

hg-pyun merged 2 commits into hg-pyun:master from brGuirra:fix/base-url-log-behavior

Jul 23, 2023

+39 −9

Contributor

brGuirra commented Apr 29, 2023

Solves the bug reported on issue #101. The method combineURLs was rewritten, and tests were added to it.


          fix: ignore the base URL when the relative one is a complete URL

6836f34

hg-pyun approved these changes

View reviewed changes

Owner

hg-pyun left a comment

LGTM

hg-pyun approved these changes

View reviewed changes


          Merge branch 'master' into fix/base-url-log-behavior

e364102

hg-pyun merged commit 64ffec5 into hg-pyun:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet